Skip to content

allow the user to specifiy a custom STACK_ROOT directory #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

allow the user to specifiy a custom STACK_ROOT directory #143

wants to merge 3 commits into from

Conversation

haitlahcen
Copy link

This PR fixes #142

@haitlahcen
Copy link
Author

@domenkozar I've done a little update

@domenkozar
Copy link
Contributor

That one fails the CI :)

@haitlahcen
Copy link
Author

The CI failed for the first change aswell, it tell me to run the script again? I don't get it :P

@domenkozar
Copy link
Contributor

@haitlahcen should be fixed now, could you rebase?

@haitlahcen
Copy link
Author

@domenkozar I've addressed a broaded concern here, what do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@domenkozar domenkozar domenkozar approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the user to specify the STACK_ROOT
2 participants
@haitlahcen @domenkozar